Re: [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions

[Paolo Bonzini]

Il 09/03/2012 12:19, David Gibson ha scritto:
>> > 
>> > This is opposite to the convention of dma_buf_read/dma_buf_write, which
>> > is from the point of view of the device.
> Uh, these are from the point of view of the device - the device writes
> to memory == transfer from device.

Right, dma_buf_read = "read from device".  The idea with dma_buf_read
was to make it the same as dma_bdrv_read().

> More importantly, this is the same
> convention as cpu_physical_memory_{read,write}() which is what these
> generally replace.

Understood.

My point was not really to bikeshed, just to note that probably
dma_buf_read/dma_buf_write become very confusing now.  So it is best to
remove them and just replace it with dma_buf_rw and a DMADirection
argument).  Can you do that?

Thanks,

Paolo