[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Xen, mapcache: Fix the compute of the size of bucket.
From: |
Anthony PERARD |
Subject: |
[Qemu-devel] Xen, mapcache: Fix the compute of the size of bucket. |
Date: |
Thu, 8 Mar 2012 15:58:04 +0000 |
Because the size of a mapping is wrong when there is an offset and a
size >= bucket_size.
Signed-off-by: Anthony PERARD <address@hidden>
---
xen-mapcache.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/xen-mapcache.c b/xen-mapcache.c
index 585b559..db6eb05 100644
--- a/xen-mapcache.c
+++ b/xen-mapcache.c
@@ -205,12 +205,14 @@ uint8_t *xen_map_cache(target_phys_addr_t phys_addr,
target_phys_addr_t size,
}
/* size is always a multiple of MCACHE_BUCKET_SIZE */
- if ((address_offset + (__size % MCACHE_BUCKET_SIZE)) > MCACHE_BUCKET_SIZE)
- __size += MCACHE_BUCKET_SIZE;
- if (__size % MCACHE_BUCKET_SIZE)
- __size += MCACHE_BUCKET_SIZE - (__size % MCACHE_BUCKET_SIZE);
- if (!__size)
+ if (size) {
+ __size = size + address_offset;
+ if (__size % MCACHE_BUCKET_SIZE) {
+ __size += MCACHE_BUCKET_SIZE - (__size % MCACHE_BUCKET_SIZE);
+ }
+ } else {
__size = MCACHE_BUCKET_SIZE;
+ }
entry = &mapcache->entry[address_index % mapcache->nr_buckets];
--
tg: (2a60546..) mapcache-fix-size (depends on: spice-debian-debug)
- [Qemu-devel] Xen, mapcache: Fix the compute of the size of bucket.,
Anthony PERARD <=