[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members |
Date: |
Wed, 7 Mar 2012 12:44:41 +0000 |
From: Stefan Weil <address@hidden>
This patch fixes warnings reported by splint:
For variables which are packed in a single bit, a signed data type
like 'int' does not make much sense.
There is no obvious reason why the two values should be packed,
so I removed the packing and changed the data type to bool
because both are used as boolean values.
Cc: Anthony Liguori <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
ui/vnc-auth-sasl.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h
index fd9b18a..ee243a9 100644
--- a/ui/vnc-auth-sasl.h
+++ b/ui/vnc-auth-sasl.h
@@ -37,9 +37,9 @@ typedef struct VncDisplaySASL VncDisplaySASL;
struct VncStateSASL {
sasl_conn_t *conn;
/* If we want to negotiate an SSF layer with client */
- int wantSSF :1;
+ bool wantSSF;
/* If we are now running the SSF layer */
- int runSSF :1;
+ bool runSSF;
/*
* If this is non-zero, then wait for that many bytes
* to be written plain, before switching to SSF encoding
--
1.7.9.1
- [Qemu-devel] [PATCH 03/13] qom: Fix spelling in documentation, (continued)
- [Qemu-devel] [PATCH 03/13] qom: Fix spelling in documentation, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 02/13] sh7750: Remove redundant 'struct' from MemoryRegionOps, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 05/13] block/vmdk: Fix warning from splint (comparision of unsigned value), Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 04/13] qmp: Fix spelling fourty -> forty, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 01/13] ppc: Add missing 'static' to spin_rw_ops, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 09/13] vnc: Add break statement, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 13/13] configure: Quote the configure args printed in config.log, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 10/13] Spelling fixes in comments (it's -> its), Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 06/13] Fix sign of sscanf format specifiers, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 11/13] libcacard: Spelling and grammar fixes in documentation, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 07/13] vnc: Fix packed boolean struct members,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 08/13] libcacard: Use format specifier %u instead of %d for unsigned values, Stefan Hajnoczi, 2012/03/07
- [Qemu-devel] [PATCH 12/13] osdep: Remove local definition of macro offsetof, Stefan Hajnoczi, 2012/03/07