Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

[Paolo Bonzini]

Il 06/03/2012 08:16, Mark Wu ha scritto:
> It seems we need a name for the union to reference its member.

What version is your compiler?

> So I
> modified the scripts as the following patch. I also updated blockdev.c
> accordingly. After that I can compile it without error. Actually, I
> don't know why we need introduce a union for BlockdevAction. Can we just
> use a void pointer like "void *action_param" to replace the union? Or
> can we change the field ."snapshot_file to "target" too? Then they can
> share the same action parameter structure.

No, the struct must match the existing blockdev-snapshot-sync command.

Paolo