[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction |
Date: |
Mon, 05 Mar 2012 12:04:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/05/2012 10:34 AM, Paolo Bonzini wrote:
> With it comes a new image creation mode, "no-backing-file", that can
> be used to stream an image so that the destination does not need the
> original image's backing file(s).
>
> Both bdrv_append and blkmirror will set the backing_hd on the target,
> even if the image is created without one, so that both streaming and
> copy-on-write work properly (at least with qcow2 or qed, not raw).
>
> Streaming mode works with the following gotchas:
>
> - streaming will rewrite every bit of the source image;
>
> - zero writes are not supported by the blkmirror driver, hence both
> the source and the destination image will grow to full size.
>
> @@ -1159,7 +1175,8 @@
> ##
> { 'union': 'BlockdevAction',
> 'data': {
> - 'blockdev-snapshot-sync': 'BlockdevSnapshot'
> + 'blockdev-snapshot-sync': 'BlockdevSnapshot',
Minor nit - should we rebase this trailing comma earlier in the series,
to make it obvious that BlockdevAction will grow and for less churn in
this patch?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions, (continued)
- [Qemu-devel] [PATCH v3 1/8] fix format name for backing file, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction, Paolo Bonzini, 2012/03/05
- Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction,
Eric Blake <=
- [Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH v3 9/8] Add the drive-reopen command, Paolo Bonzini, 2012/03/06
- [Qemu-devel] [PATCH v3 10/8] use QSIMPLEQ_FOREACH_SAFE when freeing list elements, Paolo Bonzini, 2012/03/06