Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

[Kevin Wolf]

Am 05.03.2012 10:28, schrieb Paolo Bonzini:
> Il 05/03/2012 09:53, Kevin Wolf ha scritto:
>>>>
>>>> I think we need some sort of introspection method too in order for clients 
>>>> to 
>>>> figure out when the command is extended.
>> How about coupling the types with independently available commands for
>> now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does
>> the same thing outside of transactions. The mirror patches would then
>> introduce a 'drive-mirror' top-level command at the same time as they
>> introduce a 'drive-mirror' transaction type.
> 
> Makes sense.  It would also be a good excuse to port
> blockdev-snapshot-sync to the new fail-safe way.  I'll refresh my
> patches if there's consensus.

Will you also replace 'blockdev-transaction' by 'transaction' to keep
things generic at the interface level? The necessary refactoring to
actually make it useful outside the block layer can come later, but we
can leave the external API stable then.

Kevin