[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] pci: fix bridge IO/BASE
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH] pci: fix bridge IO/BASE |
Date: |
Sun, 4 Mar 2012 11:46:14 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
commit 5caef97a16010f818ea8b950e2ee24ba876643ad introduced
a regression: we do not make IO base/limit upper 16
bit registers writeable, so we should report a 16 bit
IO range type, not a 32 bit one.
Note that PCI_PREF_RANGE_TYPE_32 is 0x0, but PCI_IO_RANGE_TYPE_32 is 0x1.
In particular, this broke sparc64.
Note: this just reverts to behaviour prior to the patch.
Making PCI_IO_BASE_UPPER16 and PCI_IO_LIMIT_UPPER16
registers writeable should, and seems to, work just as well, but
as no system seems to actually be interested in 32 bit IO,
let's not make unnecessary changes.
Reported-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Mark, can you confirm that this fixes the bug for you?
---
hw/pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index fee27fc..6d08cef 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -633,8 +633,8 @@ static void pci_init_mask_bridge(PCIDevice *d)
memset(d->wmask + PCI_PREF_BASE_UPPER32, 0xff, 8);
/* Supported memory and i/o types */
- d->config[PCI_IO_BASE] |= PCI_IO_RANGE_TYPE_32;
- d->config[PCI_IO_LIMIT] |= PCI_IO_RANGE_TYPE_32;
+ d->config[PCI_IO_BASE] |= PCI_IO_RANGE_TYPE_16;
+ d->config[PCI_IO_LIMIT] |= PCI_IO_RANGE_TYPE_16;
pci_word_test_and_set_mask(d->config + PCI_PREF_MEMORY_BASE,
PCI_PREF_RANGE_TYPE_64);
pci_word_test_and_set_mask(d->config + PCI_PREF_MEMORY_LIMIT,
--
1.7.9.111.gf3fb0
- [Qemu-devel] [PATCH] pci: fix bridge IO/BASE,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Blue Swirl, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Michael S. Tsirkin, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Blue Swirl, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Michael S. Tsirkin, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Blue Swirl, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Michael S. Tsirkin, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Blue Swirl, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Michael S. Tsirkin, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Blue Swirl, 2012/03/04
- Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE, Michael S. Tsirkin, 2012/03/04