[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: guard mmap_next_start from specific
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: guard mmap_next_start from specific maps |
|
Date: |
Sun, 4 Mar 2012 00:43:09 +0000 |
|
User-agent: |
KMail/1.13.7 (Linux/3.2.0-1-amd64; KDE/4.6.5; x86_64; ; ) |
> If the guest process tells us to map at a specific address, we shouldn't
> increase the "last automatic mapping ended here" variable.
That sounds reasonable, in fact I'd go further. Tests on an x86-linux machine
(both 32-bit and 64-bit userspace) show that if the requested address is not
available then it is completely ignored.
> + if (start == mmap_next_start && addr >= TASK_UNMAPPED_BASE) {
> + mmap_next_start = addr;
Code does not match description.
Paul