[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction |
Date: |
Fri, 02 Mar 2012 14:00:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 01.03.2012 17:52, schrieb Paolo Bonzini:
>>> But you can even keep from your first patch the drive-reopen command and
>>> not make it atomic, that shouldn't be a problem.
>>
>> I'm not sure whether it makes sense for a separate drive-reopen or
>> whether to just add this to blockdev-transaction (or even both); I can
>> make libvirt use whichever color bikeshed we pick. There's definitely a
>> transaction aspect here
>
> It's not so much atomicity, it's just safety. The drive-reopen command
> must be implemented in a similar way to bdrv_append; it must not do a
> close+reopen in the same way as the existing blockdev-snapshot-sync
> command, but that's just that blockdev-snapshot-sync was implemented
> poorly.
For reopen this is a bit harder because you deal with already opened
images and you must never have the same image opened twice at the same time.
Kevin
Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction, Anthony Liguori, 2012/03/02