Re: [Qemu-devel] [PATCH v2] w32: Support tests (make check)

[Andreas Färber]

Am 25.02.2012 17:39, schrieb Stefan Weil:
> Am 25.02.2012 17:31, schrieb Andreas Färber:
>> Am 22.02.2012 20:48, schrieb Stefan Weil:
>>> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
>>>
>>> v2:
>>> Rebased, added new tests, tests sorted alphabetically.
>>>
>>> Signed-off-by: Stefan Weil <address@hidden>
>>> ---
>>> tests/Makefile | 38 +++++++++++++++++++++++---------------
>>> 1 files changed, 23 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/tests/Makefile b/tests/Makefile
>>> index 74b29dc..09f2b13 100644
>>> --- a/tests/Makefile
>>> +++ b/tests/Makefile
>>> @@ -1,16 +1,24 @@
>>> -CHECKS = check-qdict check-qfloat check-qint check-qstring check-qlist
>>> -CHECKS += check-qjson test-qmp-output-visitor test-qmp-input-visitor
>>> -CHECKS += test-string-input-visitor test-string-output-visitor
>>> test-coroutine
>>> +CHECKS = check-qdict$(EXESUF)
>>> +CHECKS += check-qfloat$(EXESUF)
>>> +CHECKS += check-qint$(EXESUF)
>>> +CHECKS += check-qjson$(EXESUF)
>>> +CHECKS += check-qlist$(EXESUF)
>>> +CHECKS += check-qstring$(EXESUF)
>>> +CHECKS += test-coroutine$(EXESUF)
>>> +CHECKS += test-qmp-input-visitor$(EXESUF)
>>> +CHECKS += test-qmp-output-visitor$(EXESUF)
>>> +CHECKS += test-string-input-visitor$(EXESUF)
>>> +CHECKS += test-string-output-visitor$(EXESUF)
>>
>> Cute. (one-per-line allows to easily comment individual ones out)
>>
>> Some lines below were already way over 80 chars, so
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> Andreas
> 
> And as long as they remain sorted, they also reduce the risk
> of merge conflicts:
> 
> When everybody just adds to the end,two different commits
> will always conflict.
> 
> They won't conflictif both commits add new lines at different
> locations.

I'd rather not strictly keep it in alphabetical order since having one
test pass might be a prerequisite for another test to be meaningful
(e.g., qfloat before pi). IMO we should have groups of tests, in which
we can order them alphabetically.
Anyway, my line of thinking was that no such interdependency is
documented here so it should be permissible to rearrange the order now.
The q* and the visitors are still together, input before output, so I
like it. We could add lines before test-coroutine and
test-qmp-input-visitors to group them by topic if we wanted, but the
list is still small, so no real need.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg