Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly

[Andreas Färber]

Am 24.02.2012 23:18, schrieb Meador Inge:
> Fixing a simple typo, s/errno/err/, that caused
> the error status from GDB semihosted system calls
> to be returned incorrectly.
> 
> Signed-off-by: Meador Inge <address@hidden>

Nice catch!

Reviewed-by: Andreas Färber <address@hidden>

Andreas

> ---
>  m68k-semi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/m68k-semi.c b/m68k-semi.c
> index bab01ee..6d60ced 100644
> --- a/m68k-semi.c
> +++ b/m68k-semi.c
> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, 
> target_ulong err)
>      }
>      /* FIXME - handle put_user() failure */
>      put_user_u32(ret, args);
> -    put_user_u32(errno, args + 4);
> +    put_user_u32(err, args + 4);
>  }
>  
>  #define ARG(n)                                       \

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg