[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC |
Date: |
Fri, 24 Feb 2012 14:50:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
On 02/24/2012 02:47 PM, Anthony Liguori wrote:
>>
>
> I agree with you in principle, but in practice, there is not obvious way
> to serialize gpio_in/gpio_out via Visitors. Finding some way to do it
> as an integer is clearly wrong IMHO.
"%s/gpio_in[%d]" % (object_get_canonical_path(...), opaque->n) is what I
was thinking about.
> I think a simple Pin object with the following interfaces:
>
> /**
> * Connect a pin to a qemu_irq such that whenever the pin is
> * raised, qemu_irq_raise() is called too on irq.
> */
> void pin_connect_qemu_irq(Pin *obj, qemu_irq irq);
>
> /**
> * Returns a qemu_irq such that whenever qemu_irq_raise() is
> * called, pin_set_level(obj, true) is called.
> */
> qemu_irq pin_get_qemu_irq(Pin *obj);
>
> Let's you incrementally refactor objects to use Pins while maintaining the
> existing qemu_irq infrastructure.
Sure, a simple bridge is a fine alternative. What I'm not sure about is
making Pins stateful, because that means you have to serialize them.
Paolo
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, (continued)
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Igor Mammedov, 2012/02/17
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Igor Mammedov, 2012/02/24
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Andreas Färber, 2012/02/24
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Paolo Bonzini, 2012/02/24
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Anthony Liguori, 2012/02/24
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC, Anthony Liguori, 2012/02/24
[Qemu-devel] [PATCH 5/7] Set default 'model' property if it wasn't specified yet., Igor Mammedov, 2012/02/15