[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last col
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon |
Date: |
Fri, 24 Feb 2012 10:29:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 10.02.2012 07:27, schrieb Amos Kong:
> IPv6 address contains colons, parse will be wrong.
>
> [2312::8274]:5200
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index f63014c..9e1ef9e 100644
> --- a/net.c
> +++ b/net.c
> @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char
> **pp, int sep)
> const char *p, *p1;
> int len;
> p = *pp;
> - p1 = strchr(p, sep);
> + p1 = strrchr(p, sep);
> if (!p1)
> return -1;
> len = p1 - p;
And what if the port isn't specified? I think you would erroneously
interpret the last part of the IP address as port.
Kevin
- [Qemu-devel] [PATCH 0/4] support to migrate with IPv6 address, Amos Kong, 2012/02/10
- [Qemu-devel] [PATCH 1/4] Use getaddrinfo for migration, Amos Kong, 2012/02/10
- [Qemu-devel] [PATCH 2/4] net/socket: allow ipv6 for net_socket_listen_init and socket_connect_init, Amos Kong, 2012/02/10
- [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon, Amos Kong, 2012/02/10
- Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon,
Kevin Wolf <=
- [Qemu-devel] [PATCH 4/4] net: support to include ipv6 address by brackets, Amos Kong, 2012/02/10
- Re: [Qemu-devel] [PATCH 0/4] support to migrate with IPv6 address, Kevin Wolf, 2012/02/24