Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage

[Peter Maydell]

On 22 February 2012 13:47, Juan Quintela <address@hidden> wrote:
> Igor Mitsyanko <address@hidden> wrote:
>> Convert variables descr, src and dest from type target_phys_addr_t to 
>> uint32_t,
>> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables.
>> We can do it safely because:
>> 1) pxa2xx has 32-bit physical address;
>> 2) rest of the code in this file treats these variables as uint32_t;
>> 3) we shouldn't have used VMSTATE_UINTTL in the first place because this 
>> macro
>> is for target_ulong type (which can be different from target_phys_addr_t).
>
> This is an incompatible change, we need to bump the version.

Why? For the cases where this device is used, target_phys_addr_t is
always 32 bits so we aren't changing anything, surely?

-- PMM