[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] arm: clean up GIC constants.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] arm: clean up GIC constants. |
Date: |
Mon, 20 Feb 2012 17:27:14 +0000 |
On 19 February 2012 23:06, Rusty Russell <address@hidden> wrote:
> Interrupts numbers 0-31 are private to the processor interface, 32-1019 are
> general interrups. Add GIC_INTERNAL and substitute everywhere.
"interrupts".
> @@ -74,7 +76,7 @@ typedef struct gic_irq_state
> #define GIC_CLEAR_TRIGGER(irq) s->irq_state[irq].trigger = 0
> #define GIC_TEST_TRIGGER(irq) s->irq_state[irq].trigger
> #define GIC_GET_PRIORITY(irq, cpu) \
> - (((irq) < 32) ? s->priority1[irq][cpu] : s->priority2[(irq) - 32])
> + (((irq) < GIC_INTERNAL) ? s->priority1[irq][cpu] : s->priority2[(irq) -
> GIC_INTERNAL])
This line is now >80 chars and needs folding (ISTR saying this
for the first version of this patch).
Also, which patches are actually in this series? This is a 1/2,
and I also see a patch with no series indication and a 3/2 which
seems to be a respun version of that, but no 2/2...
-- PMM