[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem
From: |
Meador Inge |
Subject: |
Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write |
Date: |
Mon, 20 Feb 2012 08:12:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
On 02/18/2012 11:11 AM, Max Filippov wrote:
> Signed-off-by: Max Filippov <address@hidden>
Reviewed-by: Meador Inge <address@hidden>
> ---
> exec.c | 12 +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index b81677a..f105b43 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque,
> target_phys_addr_t addr,
> {
> check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
> switch (size) {
> - case 1: stb_phys(addr, val);
> - case 2: stw_phys(addr, val);
> - case 4: stl_phys(addr, val);
> + case 1:
> + stb_phys(addr, val);
> + break;
> + case 2:
> + stw_phys(addr, val);
> + break;
> + case 4:
> + stl_phys(addr, val);
> + break;
> default: abort();
> }
> }
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
- Re: [Qemu-devel] [PULL 00/12] target-xtensa queue, (continued)
- Re: [Qemu-devel] [PULL 00/12] target-xtensa queue, Andreas Färber, 2012/02/18
- [Qemu-devel] [PATCH 01/12] target-xtensa: define TLB_TEMPLATE for MMU-less cores, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 03/12] target-xtensa: fetch 3rd opcode byte only when needed, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 02/12] target-xtensa: implement info tlb monitor command, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 04/12] target-xtensa: add DEBUGCAUSE SR and configuration, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 05/12] target-xtensa: implement instruction breakpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 06/12] target-xtensa: add ICOUNT SR and debug exception, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write, Max Filippov, 2012/02/18
- Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write,
Meador Inge <=
- [Qemu-devel] [PATCH 08/12] exec: fix check_watchpoint exiting cpu_loop, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 09/12] exec: let cpu_watchpoint_insert accept larger watchpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 11/12] target-xtensa: add DEBUG_SECTION to overlay tool, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 10/12] target-xtensa: add DBREAK data breakpoints, Max Filippov, 2012/02/18
- [Qemu-devel] [PATCH 12/12] target-xtensa: add breakpoint tests, Max Filippov, 2012/02/18
- Re: [Qemu-devel] [PULL 00/12] target-xtensa queue, Max Filippov, 2012/02/26