[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async |
Date: |
Mon, 20 Feb 2012 13:45:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120210 Thunderbird/10.0.1 |
Hi,
>>> @@ -151,6 +171,7 @@ void qxl_render_update(PCIQXLDevice *qxl)
>>
>> dpy_update() call here. Calling that one isn't safe without grabbing
>> the qemu lock.
>
> About dpy_update, discovered it the hard way. You mean I need the lock
> for dpy_update or also before?
Any qemu code should be considered thread-unsafe unless proven
otherwise. On a quick scan I havn't noticed anything but the
dpy_update() call. It makes sense to wrap the whole loop though, so you
grab the lock only once.
cheers,
Gerd
[Qemu-devel] [RFC 6/7] qxl: use spice_qxl_update_area_dirty_async, Alon Levy, 2012/02/19
[Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/19
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Gerd Hoffmann, 2012/02/20
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/20
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Gerd Hoffmann, 2012/02/20
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/20
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Gerd Hoffmann, 2012/02/21
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/21
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Gerd Hoffmann, 2012/02/21
- Re: [Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/21