[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 22/22] hw/pl031: Actually raise interrupt on timer e
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 22/22] hw/pl031: Actually raise interrupt on timer expiry |
Date: |
Fri, 17 Feb 2012 11:29:37 +0000 |
Fix a typo in pl031_interrupt() which meant we were setting a bit
in the interrupt mask rather than the interrupt status register
and thus not actually raising an interrupt. This fix allows the
rtctest program from the kernel's Documentation/rtc.txt to pass
rather than hanging.
Reported-by: Daniel Forsgren <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Andreas Färber <address@hidden>
---
hw/pl031.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pl031.c b/hw/pl031.c
index 05b5b11..69abc4f 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -76,7 +76,7 @@ static void pl031_interrupt(void * opaque)
{
pl031_state *s = (pl031_state *)opaque;
- s->im = 1;
+ s->is = 1;
DPRINTF("Alarm raised\n");
pl031_update(s);
}
--
1.7.1
- [Qemu-devel] [PATCH 10/22] MAINTAINERS: Add maintainers for Exynos SOC., (continued)
- [Qemu-devel] [PATCH 10/22] MAINTAINERS: Add maintainers for Exynos SOC., Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 16/22] arm_boot: Pass base address of GIC CPU interface, not whole GIC, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 18/22] hw/arm_sysctl: Drop legacy init function, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 07/22] hw/lan9118: Add basic 16-bit mode support., Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 09/22] Exynos4210: added display controller implementation, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 03/22] ARM: exynos4210: UART support, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 01/22] ARM: exynos4210: IRQ subsystem support., Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 20/22] Remove unnecessary includes of primecell.h, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 15/22] hw/vexpress.c: Instantiate the motherboard CLCD, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 17/22] hw/vexpress.c: Add vexpress-a15 machine, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 22/22] hw/pl031: Actually raise interrupt on timer expiry,
Peter Maydell <=
- [Qemu-devel] [PATCH 06/22] ARM: exynos4210: MCT support., Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 08/22] hw/exynos4210.c: Add LAN support for SMDKC210., Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 14/22] hw/vexpress.c: Factor out daughterboard-specific initialization, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 02/22] ARM: Samsung exynos4210-based boards emulation, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 21/22] MAINTAINERS: Add hw/highbank.c maintainer, Peter Maydell, 2012/02/17
- [Qemu-devel] [PATCH 05/22] ARM: exynos4210: basic Power Management Unit implementation, Peter Maydell, 2012/02/17
- Re: [Qemu-devel] [PULL 00/22] arm-devs queue, Anthony Liguori, 2012/02/17