[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/1] ./configure: add option for disabling Vi
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/1] ./configure: add option for disabling VirtFS |
|
Date: |
Fri, 17 Feb 2012 11:20:56 +0000 |
On 17 February 2012 08:22, Aneesh Kumar K.V
<address@hidden> wrote:
> On Thu, 9 Feb 2012 20:31:17 -0600, Meador Inge <address@hidden> wrote:
>> --- a/configure
>> +++ b/configure
>> @@ -121,6 +121,7 @@ docs=""
>> fdt=""
>> nptl=""
>> sdl=""
>> +virtfs=""
>
> do we want to say
>
> virtfs="yes"
No. The standard pattern for configure feature options should be:
* default is to probe and use if present, not use if not present
* --enable-foo should probe and fail configure if not present
* --disable-foo should not probe and not use
See the discussion on this point on v1 of this patch:
http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg01211.html
> That would make it explicit like vnc below.
Some of our legacy options don't follow the standard pattern, alas.
-- PMM