|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev |
| Date: | Wed, 01 Feb 2012 08:29:51 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
On 01/31/2012 09:49 PM, Anthony Liguori wrote:
+ DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1), + DEFINE_PROP_PTR("pit", PCSpkState, pit),Please don't introduce a pointer property here. They cannot be used in a meaningful way in qdev. Why not register a link<TYPE_PIT> in instance_init?
I'm going to clean this up, you can leave the PTR for now. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |