[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx |
Date: |
Tue, 31 Jan 2012 15:53:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-01-31 15:50, Anthony Liguori wrote:
> On 01/31/2012 08:38 AM, Jan Kiszka wrote:
>> On 2012-01-26 20:00, Anthony Liguori wrote:
>>> ---
>>> hw/pc.c | 70
>>> ++++--------------------------------------------------
>>> hw/pc.h | 3 +-
>>> hw/piix_pci.c | 74
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>> sysemu.h | 2 -
>>> 4 files changed, 79 insertions(+), 70 deletions(-)
>>
>> How does the ISA PC get its BIOS after this change? Or did that change
>> in a step I miss right now?
>
> Oh, I broke it. I made no attempt to keep ISA PC working.
>
> The way I'd like to handle this is to introduce a ROM device so that this
> code
> would be trivialized.
Or just keep the common pc.c library as I voted for. It has its purpose,
obviously.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition, (continued)
[Qemu-devel] [PATCH 08/15] i440fx: introduce some saner naming conventions, Anthony Liguori, 2012/01/26
[Qemu-devel] [PATCH 13/15] i440fx: allocate MemoryRegion for pci memory space, Anthony Liguori, 2012/01/26
[Qemu-devel] [PATCH 12/15] i440fx-pmc: calculate PCI memory hole directly, Anthony Liguori, 2012/01/26
[Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx, Anthony Liguori, 2012/01/26
[Qemu-devel] [PATCH 15/15] i440fx: move ram initialization into i440fx-pmc, Anthony Liguori, 2012/01/26
[Qemu-devel] [PATCH 11/15] i440fx-pmc: refactor to take properties for memory geometry, Anthony Liguori, 2012/01/26
Re: [Qemu-devel] [RFC 00/15] Refactor PC machine to take advantage of QOM, Peter Maydell, 2012/01/26
[Qemu-devel] [PATCH 10/15] i440fx: move some logic to realize and make inheritance from PCIHost explicit, Anthony Liguori, 2012/01/26