[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally |
Date: |
Wed, 25 Jan 2012 14:42:10 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote:
> Because now all PCI devices are converted to qdev.
>
> Signed-off-by: Anthony Liguori <address@hidden>
Finally!
> ---
> hw/pci.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 54400ac..ab3b53d 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -159,11 +159,8 @@ void pci_device_deassert_intx(PCIDevice *dev)
> void pci_device_reset(PCIDevice *dev)
> {
> int r;
> - /* TODO: call the below unconditionally once all pci devices
> - * are qdevified */
> - if (dev->qdev.info) {
> - qdev_reset_all(&dev->qdev);
> - }
> +
> + qdev_reset_all(&dev->qdev);
>
> dev->irq_state = 0;
> pci_update_irq_status(dev);
> --
> 1.7.4.1
- [Qemu-devel] [PATCH 28/28] virtio-s390: convert to QEMU Object Model, (continued)
- [Qemu-devel] [PATCH 28/28] virtio-s390: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 23/28] unin_pci: Clean up qdev names, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 07/28] qdev: don't access name through info, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 08/28] qdev: use a wrapper to access reset and promote reset to a class method, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2), Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 06/28] qdev: move qdev->info to class, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 16/28] i2c: rename i2c_slave -> I2CSlave, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 18/28] hda-codec: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 05/28] qdev: integrate with QEMU Object Model (v2), Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally, Anthony Liguori, 2012/01/24
- Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 14/28] ccid: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 10/28] qdev: add class_init to DeviceInfo, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 13/28] usb: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 15/28] ssi: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev, Peter Maydell, 2012/01/24