qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL] VirtFS update


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PULL] VirtFS update
Date: Mon, 23 Jan 2012 11:05:25 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 01/23/2012 07:02 AM, Aneesh Kumar K.V wrote:


The following changes since commit 8c4ec5c0269bda18bb777a64b2008088d1c632dc:

   pxa2xx_keypad: fix unbalanced parenthesis. (2012-01-17 02:14:42 +0100)

are available in the git repository at:

   git://github.com/kvaneesh/QEMU.git for-upstream

for you to fetch changes up to 0700a73cfe166100cb59e28aad2c1fc5e4e952cb:

   hw/9pfs: Update MAINTAINERS file (2012-01-23 12:26:54 +0530)

  CC    libhw64/9pfs/virtio-9p-local.o
cc1: warnings being treated as errors
/home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c: In function ‘local_set_mapped_file_attr’: /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:9: error: ‘uid’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:14: error: ‘gid’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:19: error: ‘mode’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:25: error: ‘rdev’ may be used uninitialized in this function
make[1]: *** [9pfs/virtio-9p-local.o] Error 1
make: *** [subdir-libhw64] Error 2

I see a lot of build breakages come into through this tree. I understand that GCC can be fickle with -Werror but there's an easy way to solve this.

Please get your tree added to buildbot and make sure there's a successful buildbot run before you do a pull request.

Alternatively, setup multiple VMs to build test yourself. But please do something to check the build a bit more rigorously before sending future PULL requests.

Regards,

Anthony Liguori


----------------------------------------------------------------
(from the branch description for for-upstream local branch)

branch for landing changes for upstream merge

----------------------------------------------------------------
Aneesh Kumar K.V (3):
       hw/9pfs: Add new security model mapped-file.
       hw/9pfs: Fix crash when mounting with synthfs
       hw/9pfs: Update MAINTAINERS file

M. Mohan Kumar (2):
       hw/9pfs: Preserve S_ISGID
       fsdev: Fix parameter parsing for proxy helper

  MAINTAINERS                 |    6 +-
  fsdev/file-op-9p.h          |   12 +-
  fsdev/virtfs-proxy-helper.c |   10 +-
  hw/9pfs/cofile.c            |   14 ++
  hw/9pfs/virtio-9p-device.c  |    9 -
  hw/9pfs/virtio-9p-handle.c  |    4 +-
  hw/9pfs/virtio-9p-local.c   |  348 ++++++++++++++++++++++++++++++++++++++++++-
  hw/9pfs/virtio-9p.c         |    2 +-
  qemu-options.hx             |   18 ++-
  9 files changed, 388 insertions(+), 35 deletions(-)







reply via email to

[Prev in Thread] Current Thread [Next in Thread]