[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] signrom.sh: portability fix
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] signrom.sh: portability fix |
Date: |
Mon, 23 Jan 2012 15:31:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2009-07-17 16:37, Alexander Graf wrote:
>
> On 17.07.2009, at 15:23, Christoph Egger wrote:
>
>>
>> Hi!
>>
>> Attached patch makes signrom.sh working on NetBSD.
>> The output of the 'od' command leads to a syntax error
>> which breaks the build.
>
> So why replace the $(( ... )) calculation with expr then? A few lines
> below there's another $(( )) that apparently works.
Picking up this old topic again: Forking expr in this tight loop is a
very bad idea. It makes signing a fairly long running step of the build
process for any non-trivial rom (I'm about to add one of those).
Can you please provide an example output for the ${nums} variable that
used to break for you so that we can find a fork-free algorithm?
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] signrom.sh: portability fix,
Jan Kiszka <=