qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v12 4/4] arm: SoC model for Calxeda Highbank


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v12 4/4] arm: SoC model for Calxeda Highbank
Date: Fri, 20 Jan 2012 16:58:56 +0000

On 20 January 2012 16:57, Mark Langsdorf <address@hidden> wrote:
> On 01/20/2012 10:27 AM, Peter Maydell wrote:
>> It's still not clear to me from this conversation if the right
>> answer is "0", "-1" or "anything that's not a valid board ID
>> and not -1 either"...
>
> Quoting Rob from upthread:
> "0 or -1 is the right value as those are obviously meaningless."
>
> The original code that Rob wrote had a board_id of -1. That's
> the right answer.

In that case you need a patch that causes arm_boot to actually
pass -1, not 0xffff.

(Also it would be nice if the kernel barfed if (id == -1 and
there's no appended device tree), but that's not a qemu thing.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]