Re: [Qemu-devel] [PATCH v8 1/8] ARM: exynos4210: IRQ subsystem support.

[Peter Maydell]

On 19 January 2012 08:31, Evgeny Voevodin <address@hidden> wrote:
> +#define GIC_NIRQ            160

> +#include "arm_gic.c"

NB that when my current outstanding arm-devs pullreq lands
you'll need to update this to handle the changes in
http://patchwork.ozlabs.org/patch/136609/
This shouldn't be too hard -- you can use the changes that
patch makes to eg realview_gic.c as a guide. Basically the number
of IRQs is now a parameter to gic_init() rather than a #define.
(If it's possible for different Exynos4210 configurations to
have different numbers of IRQs then you can make num-irq
a qdev property as is done with a9mpcore.c, but I'm guessing
that 160 is a fixed value for the SoC and need not be configurable.)

Patch looks OK otherwise I think.

-- PMM