[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 03/15] block: add BlockJob interface for long
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 03/15] block: add BlockJob interface for long-running operations |
Date: |
Tue, 17 Jan 2012 13:33:48 +0000 |
On Tue, Jan 17, 2012 at 1:00 PM, Kevin Wolf <address@hidden> wrote:
> Am 13.01.2012 14:14, schrieb Stefan Hajnoczi:
>> +typedef struct BlockJobType {
>> + /** Derived BlockJob struct size */
>> + size_t instance_size;
>> +
>> + /** String describing the operation, part of query-block-jobs QMP API */
>> + const char *job_type;
>> +
>> + /** Optional callback for job types that support setting a speed limit
>> */
>> + int (*set_speed)(BlockJob *job, int64_t value);
>
> Would be worth mentioning what the unit of value is.
I left this open on purpose so future block jobs could support
block_job_set_speed with whatever unit makes sense for them. At the
interface level it's an arbitrary int64_t. Each block job type can
decide how to interpret the values.
I could add "The meaning of value and its units depend on the block
job type". Or do you think it's problematic to allow different
meanings?
Stefan
- [Qemu-devel] [PATCH v5 00/15] block: generic image streaming, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH v5 02/15] block: check bdrv_in_use() before blockdev operations, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH v5 05/15] block: rate-limit streaming operations, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH v5 04/15] block: add image streaming block job, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH v5 03/15] block: add BlockJob interface for long-running operations, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 07/15] qmp: add block_job_set_speed command, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 14/15] docs: describe live block operations, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 11/15] block: add bdrv_find_backing_image, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 10/15] blockdev: make image streaming safe across hotplug, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 12/15] add QERR_BASE_NOT_FOUND, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 08/15] qmp: add block_job_cancel command, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 06/15] qmp: add block_stream command, Stefan Hajnoczi, 2012/01/13
[Qemu-devel] [PATCH v5 13/15] block: add support for partial streaming, Stefan Hajnoczi, 2012/01/13