[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fas
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t |
Date: |
Mon, 16 Jan 2012 18:48:15 +0000 |
On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
> -static int8 countLeadingZeros32( uint32_t a )
> +static int_fast8_t countLeadingZeros32(uint32_t a)
> {
> #if SOFTFLOAT_GNUC_PREREQ(3, 4)
> if (a) {
> @@ -634,7 +634,7 @@ static int8 countLeadingZeros32( uint32_t a )
> return 32;
> }
> #else
> - static const int8 countLeadingZerosHigh[] = {
> + static const int_fast8_t countLeadingZerosHigh[] = {
> 8, 7, 6, 6, 5, 5, 5, 5, 4, 4, 4, 4, 4, 4, 4, 4,
> 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
> 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
> @@ -652,7 +652,7 @@ static int8 countLeadingZeros32( uint32_t a )
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
> };
It seems unlikely that anybody will actually try to compile
qemu with gcc 3 any more, but this table should probably be
an int8_t[], not int_fast8_t[]. (Both will work, but the fast
types make sense for register values rather than in-memory
lookup tables IMHO.)
-- PMM
- Re: [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h, (continued)
[Qemu-devel] [PATCH 06/14] softfloat: Replace uint16 type with uint_fast16_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 03/14] qemu-tool: Fix mixup of int64 and int64_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t, Andreas Färber, 2012/01/15
- Re: [Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t,
Peter Maydell <=
[Qemu-devel] [PATCH 08/14] softfloat: Remove unused uint8 type, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 12/14] softfloat: Replace uint64 type with uint_fast64_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 11/14] softfloat: Replace int32 type with int_fast32_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 10/14] softfloat: Replace uint32 type with uint_fast32_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 07/14] softfloat: Replace int16 type with int_fast16_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 14/14] softfloat: Replace flag type with bool, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 13/14] softfloat: Replace int64 type with int_fast64_t, Andreas Färber, 2012/01/15
Re: [Qemu-devel] [PATCH 00/14] softfloat: Use POSIX integer types - benchmarked, Peter Maydell, 2012/01/16