[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/lan9118: Add save/load support
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/lan9118: Add save/load support |
Date: |
Thu, 12 Jan 2012 10:18:49 +0000 |
On 12 January 2012 10:16, Mitsyanko Igor <address@hidden> wrote:
> Hi Peter, I have a small question. Wouldn't it be better to use uint32_t for
> variables that actually have positive values only? That would make code
> easier to understand.
The idea is to do a straightforward and easy to review conversion.
Switching from signed to unsigned changes semantics of the variable
in a way that requires review of all the code that used that variable,
so it's riskier.
-- PMM