qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support


From: Evgeny Voevodin
Subject: Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support
Date: Wed, 11 Jan 2012 09:28:57 +0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Thunderbird/3.1.16

On 01/10/2012 04:11 PM, Peter Maydell wrote:
+    case UINTP:
+        s->reg[I_(UINTP)]&= ~val;
+        /* XXX: It's the assumption that it works in this way */
Can you expand this comment a little to clarify exactly what the
assumption you're making is?
It was not clear from documentation if UINTSP register bits should be cleared inside
this "case" too. Practise has showed that should. I think, this comment
message could be removed.

--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]