Re: [Qemu-devel] [PATCH v5 08/11] hw/exynos4210.c: Boot secondary CPU.

[Peter Maydell]

On 23 December 2011 11:40, Evgeny Voevodin <address@hidden> wrote:
> +    /*
> +     * Hack: Map SECOND_CPU_BOOTREG, because it is in PMU USER5 register.
> +     */

Shouldn't we be modelling the PMU then?

> +    memory_region_init_ram(&s->bootreg_mem, NULL, "exynos4210.bootreg", 0x4);
> +    memory_region_add_subregion(system_mem, EXYNOS4210_SECOND_CPU_BOOTREG,
> +            &s->bootreg_mem);
> +


> +static int exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] = {
> +    [EXYNOS4_BOARD_NURI]     = EXYNOS4210_SECOND_CPU_BOOTREG,
> +    [EXYNOS4_BOARD_SMDKC210] = EXYNOS4210_SECOND_CPU_BOOTREG,
> +};

Is this actually likely to differ between boards, or is it really a property
of the SoC itself?

See also note in other patch about reordering and merging this patch with
an earlier one.

-- PMM