qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path
Date: Fri, 6 Jan 2012 15:51:25 +0000

From: Peter Maydell <address@hidden>

Fix a leak of a file descriptor in error exit paths in
gdbserver_open().

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 gdbstub.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index a5806ef..7d470b6 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2762,11 +2762,13 @@ static int gdbserver_open(int port)
     ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
     if (ret < 0) {
         perror("bind");
+        close(fd);
         return -1;
     }
     ret = listen(fd, 0);
     if (ret < 0) {
         perror("listen");
+        close(fd);
         return -1;
     }
     return fd;
-- 
1.7.7.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]