Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion

[Andreas Färber]

Am 03.01.2012 01:52, schrieb Anthony Liguori:
> These are various small stylistic changes which help make things more
> consistent such that the automated conversion script can be simpler.
> 
> It's not necessary to agree or disagree with these style changes because all
> of this code is going to be rewritten by the patch monkey script anyway.
> 
> Signed-off-by: Anthony Liguori <address@hidden>
> ---

> diff --git a/hw/es1370.c b/hw/es1370.c
> index 6a3ba55..3527eb6 100644
> --- a/hw/es1370.c
> +++ b/hw/es1370.c
> @@ -1041,13 +1041,8 @@ static PCIDeviceInfo es1370_info = {
>      .vendor_id    = PCI_VENDOR_ID_ENSONIQ,
>      .device_id    = PCI_DEVICE_ID_ENSONIQ_ES1370,
>      .class_id     = PCI_CLASS_MULTIMEDIA_AUDIO,
> -#if 1
>      .subsystem_vendor_id = 0x4942,
>      .subsystem_id = 0x4c4c,
> -#else
> -    .subsystem_vendor_id = 0x1274,
> -    .subsystem_id = 0x1371,
> -#endif
>  };
>  
>  static void es1370_register (void)

It is worth noting that this is *not* a stylistic change but actually
dropping device information from the tree.

malc, what is the meaning of the currently unused values? Would it make
sense to move them to a separate PCIDeviceInfo so that they survive the
QOM introduction?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg