[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned fu
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function |
Date: |
Wed, 4 Jan 2012 12:00:41 +0000 |
On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman <address@hidden> wrote:
> +static inline void *host_from_stream_offset_versioned(int version_id,
> + QEMUFile *f, ram_addr_t offset, int flags)
> +{
> + void *host;
> + if (version_id == 3) {
> + host = qemu_get_ram_ptr(offset);
> + } else {
> + host = host_from_stream_offset(f, offset, flags);
> + }
> + if (!host) {
> + fprintf(stderr, "Failed to convert RAM address to host"
> + " for offset 0x%lX!\n", offset);
> + abort();
> + }
Please use RAM_ADDR_FMT instead of %lX.
Aborting isn't ideal but I guess there is nothing else we can do at this point.
Stefan
[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/01/03