qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info
Date: Tue, 03 Jan 2012 10:06:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/03/2012 01:51 AM, Anthony Liguori wrote:
      d->nic = qemu_new_nic(&net_e1000_info,&d->conf,
-                          qdev_get_info(&d->dev.qdev)->name, d->dev.qdev.id, 
d);
+                          object_get_typename(OBJECT(d)), d->dev.qdev.id, d);

It's a pity that this loses type-safety.

Perhaps we should look at adding a warning for "unsafe" pointer casts to GCC.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]