qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types
Date: Tue, 03 Jan 2012 08:58:10 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/03/2012 03:33 AM, Avi Kivity wrote:
> -    if ((pd & ~TARGET_PAGE_MASK) > IO_MEM_ROM && !(pd & IO_MEM_ROMD)) {
> +    if (!is_ram_rom(pd) && !(pd & IO_MEM_ROMD)) {
>          /* IO memory case (romd handled later) */

Perhaps (!is_ram_rom_romd(pd))?

At least that's what I see from DeMorgan's, even though it
doesn't quite seem to tally with the comment...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]