[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/9] arm: Set frequencies for arm_timer

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 2/9] arm: Set frequencies for arm_timer
Date: Sat, 24 Dec 2011 00:26:04 +0000

On 22 December 2011 18:20, Mark Langsdorf <address@hidden> wrote:
> Use qdev properties to allow board modelers to set the frequencies
> for the sp804 timer. Each of the sp804's timers can have an
> individual frequency. The timers default to 1MHz.
> +    /* The timers are configurable between 32kHz and 1MHz
> +     * defaulting to 1MHz but overrideable as a property
> +     * They can be configured individually as a property
> +     * but default is shared frequency */

You've forgotten to update this comment when you dropped the
shared-frequency property. Patch looks good otherwise.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]