[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 25/26] qemu-nbd: throttle requests
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 25/26] qemu-nbd: throttle requests |
Date: |
Fri, 23 Dec 2011 16:26:29 +0100 |
Limiting the number of in-flight requests is implemented very simply
with a can_read callback. It does not require a semaphore, unlike the
client side in block/nbd.c, because we can throttle directly the creation
of coroutines. The client side can have a coroutine created at any time
when an I/O request is made.
Signed-off-by: Paolo Bonzini <address@hidden>
---
nbd.c | 25 ++++++++++++++++++++++---
1 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/nbd.c b/nbd.c
index 6d7d1f8..567e94e 100644
--- a/nbd.c
+++ b/nbd.c
@@ -587,6 +587,8 @@ static int nbd_send_reply(int csock, struct nbd_reply
*reply)
return 0;
}
+#define MAX_NBD_REQUESTS 16
+
typedef struct NBDRequest NBDRequest;
struct NBDRequest {
@@ -614,6 +616,8 @@ struct NBDClient {
CoMutex send_lock;
Coroutine *send_coroutine;
+
+ int nb_requests;
};
static void nbd_client_get(NBDClient *client)
@@ -644,6 +648,9 @@ static NBDRequest *nbd_request_get(NBDClient *client)
NBDRequest *req;
NBDExport *exp = client->exp;
+ assert(client->nb_requests <= MAX_NBD_REQUESTS - 1);
+ client->nb_requests++;
+
if (QSIMPLEQ_EMPTY(&exp->requests)) {
req = g_malloc0(sizeof(NBDRequest));
req->data = qemu_blockalign(exp->bs, NBD_BUFFER_SIZE);
@@ -660,6 +667,9 @@ static void nbd_request_put(NBDRequest *req)
{
NBDClient *client = req->client;
QSIMPLEQ_INSERT_HEAD(&client->exp->requests, req, entry);
+ if (client->nb_requests-- == MAX_NBD_REQUESTS) {
+ qemu_notify_event();
+ }
nbd_client_put(client);
}
@@ -688,6 +698,7 @@ void nbd_export_close(NBDExport *exp)
g_free(exp);
}
+static int nbd_can_read(void *opaque);
static void nbd_read(void *opaque);
static void nbd_restart_write(void *opaque);
@@ -699,7 +710,8 @@ static int nbd_co_send_reply(NBDRequest *req, struct
nbd_reply *reply,
int rc, ret;
qemu_co_mutex_lock(&client->send_lock);
- qemu_set_fd_handler2(csock, NULL, nbd_read, nbd_restart_write, client);
+ qemu_set_fd_handler2(csock, nbd_can_read, nbd_read,
+ nbd_restart_write, client);
client->send_coroutine = qemu_coroutine_self();
if (!len) {
@@ -724,7 +736,7 @@ static int nbd_co_send_reply(NBDRequest *req, struct
nbd_reply *reply,
}
client->send_coroutine = NULL;
- qemu_set_fd_handler2(csock, NULL, nbd_read, NULL, client);
+ qemu_set_fd_handler2(csock, nbd_can_read, nbd_read, NULL, client);
qemu_co_mutex_unlock(&client->send_lock);
return rc;
}
@@ -900,6 +912,13 @@ out:
nbd_client_close(client);
}
+static int nbd_can_read(void *opaque)
+{
+ NBDClient *client = opaque;
+
+ return client->recv_coroutine || client->nb_requests < MAX_NBD_REQUESTS;
+}
+
static void nbd_read(void *opaque)
{
NBDClient *client = opaque;
@@ -931,6 +950,6 @@ NBDClient *nbd_client_new(NBDExport *exp, int csock,
client->sock = csock;
client->close = close;
qemu_co_mutex_init(&client->send_lock);
- qemu_set_fd_handler2(csock, NULL, nbd_read, NULL, client);
+ qemu_set_fd_handler2(csock, nbd_can_read, nbd_read, NULL, client);
return client;
}
--
1.7.7.1
- [Qemu-devel] [PATCH 10/26] Update ioctl order in nbd_init() to detect EBUSY, (continued)
- [Qemu-devel] [PATCH 10/26] Update ioctl order in nbd_init() to detect EBUSY, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 12/26] qemu-nbd: remove data_size argument to nbd_trip, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 13/26] move corking functions to osdep.c, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 14/26] qemu-nbd: simplify nbd_trip, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 15/26] qemu-nbd: introduce nbd_do_send_reply, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 16/26] qemu-nbd: more robust handling of invalid requests, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 19/26] qemu-nbd: introduce NBDRequest, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 20/26] link the main loop and its dependencies into the tools, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 22/26] qemu-nbd: move client handling to nbd.c, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 21/26] qemu-nbd: use common main loop, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 25/26] qemu-nbd: throttle requests,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 26/26] nbd: add myself as maintainer, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 07/26] nbd: add support for NBD_CMD_FLAG_FUA, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 09/26] nbd: add support for NBD_CMD_TRIM, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 24/26] qemu-nbd: asynchronous operation, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 11/26] qemu-nbd: remove offset argument to nbd_trip, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 17/26] qemu-nbd: introduce nbd_do_receive_request, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 23/26] qemu-nbd: add client pointer to NBDRequest, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 18/26] qemu-nbd: introduce NBDExport, Paolo Bonzini, 2011/12/23
- Re: [Qemu-devel] [PULL 00/26] nbd refactoring, fully asynchronous operation, flushing, fixes, Anthony Liguori, 2011/12/27