[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] VMDK: footer must take precedence over header when pres
Re: [Qemu-devel] VMDK: footer must take precedence over header when present
Thu, 22 Dec 2011 09:54:12 +0000
On Wed, Dec 21, 2011 at 11:34 PM, B Gordon <address@hidden> wrote:
> VMDK: footer must take precedence over header when present
> In e.g. streamOptimized VMDKs from VSphere 4 with this flag set the
> header l1_table is bogus and only the footer l1_table can be used to
> correctly read extents.
> Also reverts recent change to VMDK4Header so order of rgd_ and
> gd_offset matches the VMDK spec.
In commit bb45ded93115ad4303471c9a492579dc36716547 you moved the
rgd_offset field after gd_offset. The VMDK spec has the rgd_offset
field before gd_offset.
Could you please review B.B. Gordon's patch which reverts this change
and implements the header/footer precedence described in the "Header
and Footer" section for Stream-Optimized Compressed Sparse Extents?
If you still have the .vmdk files you tested against it would be
interesting to verify that applying this new patch doesn't break them.