[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr
Date: Wed, 21 Dec 2011 17:15:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/21/2011 03:55 PM, Anthony Liguori wrote:
> On 12/21/2011 07:34 AM, Avi Kivity wrote:
>> ram_addr is (a) unstable (b) going away.  Sort by idstr instead.
>> Signed-off-by: Avi Kivity<address@hidden>
> I don't see this as a problem, per say, but this is a significant
> behavioral change.  ram_addr does correspond roughly to the location
> in memory and historically we would send memory starting from 0 upward
> whereas now, the order that we send RAMBlocks will be random for all
> intents and purposes.
> Again, I don't think it's a problem, but we should note this in the
> commit message in case it creates a problem down the road.

I (and the new commit message) note that the sort order used to be
random a while ago (before b2e0a138e), so this isn't entirely new.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]