[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 24/27] grackle: remove broken pci device
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] [PATCH 24/27] grackle: remove broken pci device |
Date: |
Tue, 20 Dec 2011 10:51:53 -0600 |
I have no idea what's going on here, but this is broken and cannot possibly
work because:
1) It's qdev name conflicts with a device that sits on SysBus
2) The PCI constructor expects a SysBus device... but's it's a PCIDevice
If you do qdev_create("grackle"), the code expects to get the SysBus version
so drop the mystery PCI version.
Signed-off-by: Anthony Liguori <address@hidden>
---
hw/grackle_pci.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c
index 1e529fb..84f1a47 100644
--- a/hw/grackle_pci.c
+++ b/hw/grackle_pci.c
@@ -115,27 +115,10 @@ static int pci_grackle_init_device(SysBusDevice *dev)
return 0;
}
-static int grackle_pci_host_init(PCIDevice *d)
-{
- d->config[0x09] = 0x01;
- return 0;
-}
-
-static PCIDeviceInfo grackle_pci_host_info = {
- .qdev.name = "grackle",
- .qdev.size = sizeof(PCIDevice),
- .init = grackle_pci_host_init,
- .vendor_id = PCI_VENDOR_ID_MOTOROLA,
- .device_id = PCI_DEVICE_ID_MOTOROLA_MPC106,
- .revision = 0x00,
- .class_id = PCI_CLASS_BRIDGE_HOST,
-};
-
static void grackle_register_devices(void)
{
sysbus_register_dev("grackle", sizeof(GrackleState),
pci_grackle_init_device);
- pci_qdev_register(&grackle_pci_host_info);
}
device_init(grackle_register_devices)
--
1.7.4.1
- [Qemu-devel] [PATCH 14/27] ssi: convert to QEMU Object Model, (continued)
- [Qemu-devel] [PATCH 14/27] ssi: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 15/27] i2c: rename i2c_slave -> I2CSlave, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 17/27] hda-codec: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 19/27] scsi: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 26/27] pci: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- Re: [Qemu-devel] [PATCH 00/27] qom: add QEMU Object Model type hierarchy to qdev, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 23/27] virtio-serial: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 21/27] spapr: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 18/27] ide: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 25/27] unin_pci: remove phantom qdev devices in unin_pci, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 24/27] grackle: remove broken pci device,
Anthony Liguori <=
- [Qemu-devel] [PATCH 20/27] not-for-upstream: spapr: break default console, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 16/27] i2c: smbus: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 27/27] sysbus: convert to QEMU Object Model, Anthony Liguori, 2011/12/20
- [Qemu-devel] [PATCH 22/27] not-for-upstream: virtio-serial: stub out a strange hack, Anthony Liguori, 2011/12/20