[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip sup

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support
Date: Mon, 19 Dec 2011 18:32:41 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 12/19/2011 05:49 PM, Jan Kiszka wrote:
On 2011-12-19 23:24, Anthony Liguori wrote:
On 12/19/2011 03:17 PM, Marcelo Tosatti wrote:


Can you please review&   ACK?

You could even apply directly but well do a kvm-autotest run through
uq/master. Still, your review is needed.

Overall, it looks good except for the backend/frontend split.  This
should be done in terms of qdev inheritance.

I cannot follow your idea here yet. There is no inheritance as we end up
with only a single class that permutes (selects a different backend) on
creation. I'm not sure how to model two classes that will still only
mean a single qdev registration.

See other reply in thread.

We should model this as two separate qdev devices. We can avoid regressing migration in qemu-kvm by just having a common vmstate name.

apic is a no-user device so there's no way that changing the name of it in qemu-kvm can affect users.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]