[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/17] ide: drop argument to dma_buf_commit
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 01/17] ide: drop argument to dma_buf_commit |
Date: |
Mon, 19 Dec 2011 11:12:22 +0000 |
From: Paolo Bonzini <address@hidden>
The argument is unused and even wrong when the function is called
by ide_handle_rw_error. Drop it.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/ide/core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 49847bd..753c442 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -493,7 +493,7 @@ void ide_sector_read(IDEState *s)
}
}
-static void dma_buf_commit(IDEState *s, int is_write)
+static void dma_buf_commit(IDEState *s)
{
qemu_sglist_destroy(&s->sg);
}
@@ -532,7 +532,7 @@ static int ide_handle_rw_error(IDEState *s, int error, int
op)
bdrv_iostatus_set_err(s->bs, error);
} else {
if (op & BM_STATUS_DMA_RETRY) {
- dma_buf_commit(s, 0);
+ dma_buf_commit(s);
ide_dma_error(s);
} else {
ide_rw_error(s);
@@ -566,7 +566,7 @@ handle_rw_error:
n = s->io_buffer_size >> 9;
sector_num = ide_get_sector(s);
if (n > 0) {
- dma_buf_commit(s, ide_cmd_is_read(s));
+ dma_buf_commit(s);
sector_num += n;
ide_set_sector(s, sector_num);
s->nsector -= n;
--
1.7.7.3
- [Qemu-devel] [PULL 00/17] Trivial patches for 7 to 19 December 2011, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 02/17] Makefile.target: Remove unnecessary dependency rules, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 03/17] stellaris: Calculate system clock period on reset, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 06/17] Also create piix3 property when Xen is enabled, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 04/17] kvm: Print something before calling abort() if KVM_RUN fails, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 07/17] configure: Fix compiler warnings in config.log (always return a value from main), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 05/17] slirp: Fix typo in net_slirp_hostfwd_remove, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 01/17] ide: drop argument to dma_buf_commit,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/17] configure: Fix compiler warning in config.log (integer from pointer), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 08/17] configure: Fix compiler warnings in config.log (old-style function definition), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 12/17] configure: Fix compiler warning in config.log (macro redefined), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 16/17] configure: Fix compiler warnings in config.log (statement without effect), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 14/17] configure: Fix compiler warning in config.log (undefined NULL), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 15/17] configure: Fix compiler warning in config.log (value was never used), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 13/17] configure: Fix compiler warnings in config.log (uninitialized variable), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 17/17] configure: Improve Xen autodetection for hosts without Xen, Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 11/17] configure: Fix compiler warning in config.log (unused variable), Stefan Hajnoczi, 2011/12/19
- [Qemu-devel] [PATCH 10/17] configure: Fix compiler warnings in config.log (null arguments), Stefan Hajnoczi, 2011/12/19