[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] early_savevm

From: Avi Kivity
Subject: Re: [Qemu-devel] early_savevm
Date: Sun, 18 Dec 2011 19:43:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/13/2011 01:55 PM, Stefano Stabellini wrote:
> A bit more context to my suggestion:
> - we open the save state file and check the magic number and the
> version number before machine->init();
> - we add a new set of entries to the save state file that contains
> early_savevm functions: they are called before machine->init();
> - after reaching the end of the early_savevm functions we stop parsing
> the save state file and we call machine->init();
> - after machine->init() is completed we continue parsing the save state
> file as usual.

I think this is fragile.  In the general case you can't describe the
framebuffer BAR with just a single number, it may be partially obscured
by another BAR.  It's better to fix this behind the scenes.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]