[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/8] qom: introduce get/set methods for Property

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 6/8] qom: introduce get/set methods for Property
Date: Fri, 16 Dec 2011 08:05:46 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/16/2011 07:51 AM, Paolo Bonzini wrote:
On 12/16/2011 02:11 PM, Gerd Hoffmann wrote:
I think we should not touch these. First it doesn't buy us much as we
are using the old parse/print functions for the visitor-based access,
which doesn't look like a good idea to me. Also they will not stay but
will be converted to child<> and link<>, so I think it is better to keep
the old stuff in the legacy<> namespace.

I thought the same initially. However, I noticed that the visitor interfaces for
links is also a string. So, even if a block/char/netdev property later becomes a
link<>, the interface would not change.

The semantics change though. A "drive" link takes a flat block device name. When it's converted to a link, it will take a QOM path. Since block devices will exist in their own directory, it will certainly still be possible to use the flat block device name but since a paths will also be supported, I think it's best to clearly distinguish the link based property from the flat block device name property.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]