Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree

[Kevin Wolf]

Am 16.12.2011 11:17, schrieb Paolo Bonzini:
> On 12/16/2011 10:42 AM, Kevin Wolf wrote:
>>>>
>>>>  Applied.
>>>>
>>>>  Regards,
>>>>
>>>>  Anthony Liguori
>> So you pushed this with qdev_property_add_child() calls spread all over
>> the place instead of being treated like other properties?:-(
> 
> I think actually this is not the biggest problem.  child properties are 
> dynamic, and it's not a problem IMO if they are created like that.

That they are added in an init function is an indicator that they aren't
really dynamic. Some of them are conditional, some aren't. For those
which are, I think having a child property that can be NULL could be
reasonable. In the end you want to have this kind of things configurable
via QOM instead of hard-coded in the devices, right?

> I don't like that _link_ properties are spread all over the place 
> instead of being treated like other properties.  Link properties are 
> static, and PROP_PTR properties could often be converted to links.

Yes, links too.

Kevin