[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 14/14] qiov: prevent double free or use-after-free

From: Kevin Wolf
Subject: [Qemu-devel] [PATCH 14/14] qiov: prevent double free or use-after-free
Date: Thu, 15 Dec 2011 15:09:29 +0100

From: Paolo Bonzini <address@hidden>

qemu_iovec_destroy does not clear the QEMUIOVector fully, and the data
could thus be used after free or freed again.  While I do not know any
example in the tree, I observed this using virtio-scsi (and SCSI
scatter/gather) when canceling DMA requests.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
 cutils.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/cutils.c b/cutils.c
index 6db6304..24b3fe3 100644
--- a/cutils.c
+++ b/cutils.c
@@ -217,7 +217,10 @@ void qemu_iovec_destroy(QEMUIOVector *qiov)
     assert(qiov->nalloc != -1);
+    qemu_iovec_reset(qiov);
+    qiov->nalloc = 0;
+    qiov->iov = NULL;
 void qemu_iovec_reset(QEMUIOVector *qiov)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]