[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci
Date: Thu, 15 Dec 2011 09:10:20 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/15/2011 02:17 AM, Stefan Hajnoczi wrote:
On Wed, Dec 14, 2011 at 06:10:17PM -0600, Anthony Liguori wrote:
Untested, but seemingly obvious and hard to screw up..

Sounds like a challenge so let's take a look...

-void usb_ohci_init_pci(struct PCIBus *bus, int devfn)
+USBBus *usb_ohci_init_pci(struct PCIBus *bus, int devfn)
-    pci_create_simple(bus, devfn, "pci-ohci");
+    PCIDevice *dev = pci_create_simple(bus, devfn, "pci-ohci");
+    OHCIPCIState *ohci = DO_UPCAST(OHCIPCIState, pci_dev, dev);
+    return&ohci->state.bus

Missing semicolon.

Heh, awesome :-)  Okay, I'll actually test it next time.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]