[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci
Date: Thu, 15 Dec 2011 08:17:29 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Dec 14, 2011 at 06:10:17PM -0600, Anthony Liguori wrote:
> Untested, but seemingly obvious and hard to screw up..

Sounds like a challenge so let's take a look...

> -void usb_ohci_init_pci(struct PCIBus *bus, int devfn)
> +USBBus *usb_ohci_init_pci(struct PCIBus *bus, int devfn)
>  {
> -    pci_create_simple(bus, devfn, "pci-ohci");
> +    PCIDevice *dev = pci_create_simple(bus, devfn, "pci-ohci");
> +    OHCIPCIState *ohci = DO_UPCAST(OHCIPCIState, pci_dev, dev);
> +
> +    return &ohci->state.bus

Missing semicolon.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]