[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan
Date: Wed, 14 Dec 2011 16:37:51 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/14/2011 04:23 PM, Stefan Weil wrote:
Am 14.12.2011 22:51, schrieb Anthony Liguori:

Look carefully at:




There's a significant difference :-)


Anthony Liguori

I tried the following declaration:

typedef struct sMemoryRegionOps {
uint64_t (*read)(void *opaque,
target_phys_addr_t addr,
unsigned size);
void (*write)(void *opaque,
target_phys_addr_t addr,
uint64_t data,
unsigned size);

enum device_endian endianness;

MemoryRegionGuestConstraints valid;
MemoryRegionInternalConstraints impl;

const MemoryRegionPortio *old_portio;
const MemoryRegionMmio old_mmio;
} MemoryRegionOps;

See the result here:

Interesting, but it wouldn't be possible to do a forward declaration?

I think my patch to gtk-doc (make _ optional) seems reasonable and I think that's a bit nicer than doing struct sCamelCase too.

That doesn't help with C++ compatibility but now that it is not in favor of my argument, I no longer care about it ;-) (j/k)


Anthony Liguori

Stefan Weil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]